Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export non-routing types too #90

Closed
davidlj95 opened this issue Dec 17, 2023 · 0 comments · Fixed by #194
Closed

Export non-routing types too #90

davidlj95 opened this issue Dec 17, 2023 · 0 comments · Fixed by #194
Labels
enhancement New feature or request

Comments

@davidlj95
Copy link
Owner

Currently, we export XMetadataRouteData so that you can write type-safe metadata objects. However, those types are for routes only. So when using metadata types that are not for routes, you don't have types for that.

For instance, when setting defaults:

https://github.com/davidlj95/chrislb/blob/8d9e6049154042c801a8efef30cc3be799979b12/src/app/app.module.ts#L45-L58

Or when calling the metadata service:

https://github.com/davidlj95/chrislb/blob/8d9e6049154042c801a8efef30cc3be799979b12/src/app/about-page/about-page.component.ts#L54-L56

@davidlj95 davidlj95 added the enhancement New feature or request label Dec 17, 2023
@davidlj95 davidlj95 linked a pull request Jan 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant