Compiled failed in Mac OSX for pre-release 7

[rickyzhang82]

Build commit 4e5e337 (tag: sdl2-prerelease7) through autotools in Mac OS X. It failed:

make
g++ -I../MacOSX -I./../include -I./. -I. -I./../CrossPlatform -I./../uae_cpu -I./../slirp -DHAVE_CONFIG_H  -DOS_darwin -DUNALIGNED_PROFITABLE -DX86_64_ASSEMBLY -DOPTIMIZED_FLAGS -DFPU_IEEE -D_REENTRANT -DDATADIR=\"/usr/local/share/BasiliskII\" -g -O2 -D_THREAD_SAFE -I/opt/local/include/SDL2 -I/opt/local/include -fno-merge-constants -fno-gcse-sm -mdynamic-no-pic -D_REENTRANT -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include -I/opt/local/include/pango-1.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include -I/opt/local/include/cairo -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include/libpng16 -I/opt/local/include -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/libpng16 -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/freetype2 -c ./../SDL/video_sdl2.cpp -o obj/video_sdl2.o
clang: warning: optimization flag '-fno-merge-constants' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-fno-gcse-sm' is not supported [-Wignored-optimization-argument]
./../SDL/video_sdl2.cpp:782:29: error: expected expression
    sdl_update_video_rect = {0,0,0,0};
                            ^
./../SDL/video_sdl2.cpp:890:29: error: expected expression
    sdl_update_video_rect = {0,0,0,0};
                            ^
2 errors generated.
make: *** [obj/video_sdl2.o] Error 1

[rickyzhang82]

BTW, do you want to try CI tool?

[rickyzhang82]

I added Travis CI in my PR branch. See here.

I tried to let it build in both Linux and Mac OSX. But I don't know why Mac OS X env is so slow to start. It may spend time in building SDL and GTK+ from homebrew. So in the end I have to remove Mac OS X build environment.

To resolve the problem above automatically, we need to figure out how to automate build in Mac OS X easily.

[DavidLudwig]

I fixed this shortly after releasing PR7, via a new commit, 7a52abd

CI does sound interesting, however, I would be more interested in trying to get this setup for the main, Basilisk II + SheepShaver repo, at this point.

[DavidLudwig]

Thanks for the bug report on this!

[DavidLudwig]

I could see CI being worth it at this point though. I'll give it some thought + research.

[rickyzhang82]

I will send a PR to upstream but this require repo owner setup.