Clarify piece representation in infer_pieces.py

[davidmallasen]

The third dimension in

LiveChess2FEN/lc2fen/infer_pieces.py

Line 80 in 7693a47

value = tops[0][0][0] # B

corresponds to the inverse of __PREDS_DICT. This could be made clearer.

[nayan2167]

I would like to work on this issue

[davidmallasen]

Great @nayan2167 ! If you need some help let me know. You can open a pull request referencing this issue when you do it.

[nayan2167]

Hi @David-davidlxl I went through infer_pieces.py infer_pieces.py
can you explain a bit more about what exactly Is problem statement?

[David-davidlxl]

Hi @nayan2167 I'm not sure what you're asking--are you asking what "infer_pieces.py" does? Or what you need to do with clarifying the piece representation?

[nayan2167]

Hi @David-davidlxl what do I need to do with clarifying the piece representation that's my question

[David-davidlxl]

The issue was opened by @davidmallasen but my guess is that he wanted to have more comments in the code related to the interpretation of tops

[nayan2167]

yes! Exactly what is tops and how it Is related to __preds_dict, that is what I am asking

[David-davidlxl]

Lol. If I explained everything here, there'd be no point of you performing the clarification. You should work through the code to understand what exactly it is. Otherwise I'd be happy to take over the issue and open a pull request later

[nayan2167]

so I just have to update docstring by explaining about tops and update comments

[davidmallasen]

Hello @nayan2167 @David-davidlxl . Sorry for the delay in responding.

Thanks for updating the comments, I will merge in the pull request! However, my initial idea was to clarify the actual code. Since the third dimension of those variables corresponds to the inverse of the __PREDS_DICT dictionary, I believe creating a reverse dictionary would avoid the use of "magic numbers" in the code. For example, the inverse of B would be 0, the inverse of N would be 2, etc.

Please let me know if you need further help/clarification.