Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ollama-curated.yaml #411

Merged
merged 3 commits into from
May 11, 2024
Merged

Update ollama-curated.yaml #411

merged 3 commits into from
May 11, 2024

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented May 11, 2024

Hello

While working on https://github.com/tryAGI/LangChain (hello from the .NET version) and .NET SDK (https://github.com/tryAGI/Ollama) I found some inaccuracies in the current specification (I compared with other implementations) and I want to offer you an updated version

@davidmigloz davidmigloz self-requested a review May 11, 2024 08:44
@davidmigloz
Copy link
Owner

Hey @HavenDV ,

Thanks for opening the PR, I appreciate it (and great to see cross-collaboration between other LangChain ports!).

Your changes look good (apart from the comment about the streaming, which is a limitation on our side). I've reviewed the Ollama Go client and aligned some more fields that we were missing. It should be fully up-to-date now 🙂

@davidmigloz davidmigloz added this to the v0.8.0 milestone May 11, 2024
@davidmigloz davidmigloz self-requested a review May 11, 2024 15:31
@davidmigloz davidmigloz added t:enhancement New feature or request p:ollama_dart ollama_dart package. labels May 11, 2024
@davidmigloz davidmigloz merged commit 326212c into davidmigloz:main May 11, 2024
1 check passed
@HavenDV
Copy link
Contributor Author

HavenDV commented May 18, 2024

@davidmigloz I found another problem, it seems that you need to replace the name parameter with digest and specify that it is in: path. The current entry is meaningless because {digest} is not defined

  /blobs/{digest}:
    head:
      operationId: checkBlob
      tags:
        - Models
      summary: Check to see if a blob exists on the Ollama server which is useful when creating models.
      parameters:
        - in: query
          name: name
          schema:
            type: string
          required: true
          description: the SHA256 digest of the blob
          example: sha256:c8edda1f17edd2f1b60253b773d837bda7b9d249a61245931a4d7c9a8d350250
      responses:
        '200':
          description: Blob exists on the server
        '404':
          description: Blob was not found
    post:
      operationId: createBlob
      tags:
        - Models
      summary: Create a blob from a file. Returns the server file path.
      parameters:
        - in: query
          name: name
          schema:
            type: string
          required: true
          description: the SHA256 digest of the blob
          example: sha256:c8edda1f17edd2f1b60253b773d837bda7b9d249a61245931a4d7c9a8d350250
      requestBody:
        content:
          application/octet-stream:
            schema:
              type: string
              format: binary
      responses:
        '201':
          description: Blob was successfully created

@davidmigloz
Copy link
Owner

@HavenDV fixed (#430)!
Thanks again 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:ollama_dart ollama_dart package. t:enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants