Skip to content

davidmilo/ninja.js

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

21 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

React Interview

This project contains a simple React application to display a paginated table of users which can be filtered.

The required features are working and have already been implemented, but the implementation can be improved in many different ways.

Given the existing solution, refactor and tidy the code to what you believe would be a best implementation. The goal is to end up with a more flexible solution to be able to accommodate further required features. Focus on best practices when it comes to react/state management/clean code.

During the interview, you will be asked to take us through your changes and maybe do some live coding on the spot.

If there are things you do not get to implement because of complexiy or time shortage, mention them in your PR so we know you thought about it.

When you make a PR, write down changes you did with a small explanation why.

Run the code

To get started:

  • clone
  • yarn install
  • yarn start

To run the tests:

  • yarn run test

How to submit

  1. Fork this repo.

  2. Make a PR to your forked repo with your changes (make sure you make PR on your forked repo and not on this one - by default github will choose this repo as destination for PR)

  3. We really prefer if you make public repo. There are lot of challenges with private repos:

  • you need to invite different people from karnov so they can review your code
  • invitations expire or they easily get lost in mailboxes
  • if we want to share the repo with additional people in the organisation, we have to ask you to do it.

If you chose to do public repo, send us link to the PR in your forked repo. If you choose to make private repo, add davidmilo, jacobjuul, optiguy, ignaciomartinelias, JeppeHellerBylov, mzedeler as collaborators and send us link to it.

Tips

DON'T

  • Do not rewrite code to TypeScript. Purpose of this excercise is not to see if you can rewrite code to TypeScript.
  • Do not overcomplicate the solution - real seniority comes from making complex problems simple.

DO

We like:

  • clean code
  • easy to read code
  • easy to change code
  • reusable code
  • tested code

Above concepts are open for interpretation. We want to see what they mean to you. Try to show it to us.

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published