Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkbox styles #48

Open
davidmyersdev opened this issue Nov 15, 2022 · 6 comments
Open

Update checkbox styles #48

davidmyersdev opened this issue Nov 15, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@davidmyersdev
Copy link
Owner

Checkboxes should match the container background color (or be closer in color) with a border that provides a high contrast with the background.

@demetrius-mp
Copy link
Contributor

image
image

you want to change this orange-ish border?
on dark mode it has high contrast with the background, but on light mode it is not so high.

i didnt understand which part of the checkbox should match the container background

@davidmyersdev
Copy link
Owner Author

I should have added more info to this issue. I'm actually talking about the checkbox overlay that is rendered when the following option is enabled.

ink(el, { interface: { lists: true } })

Here is what it looks like with that option enabled.

image

@demetrius-mp
Copy link
Contributor

image
i guess that on light mode this is already achieved, right? when it is not checked, the inner part of the box matches the background color, and the border has high contrast.

image
however, on dark mode, when its not checked it stays the same as white mode.

correct me if im wrong, but what you want is to, on dark mode, make the inner box closer to the background, and the border to have high contrast. is that it?

@davidmyersdev
Copy link
Owner Author

That's correct!

@demetrius-mp
Copy link
Contributor

i tried to style the inner box with css but i wasnt able to 😢

well, at least now the issue is more clear and maybe someone else can fix this

@davidmyersdev
Copy link
Owner Author

No worries at all. I appreciate you taking a stab at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants