Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Current Components & New Features #16

Open
11 of 13 tasks
davidruvolo51 opened this issue Jun 24, 2020 · 4 comments
Open
11 of 13 tasks

Improvements to Current Components & New Features #16

davidruvolo51 opened this issue Jun 24, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@davidruvolo51
Copy link
Owner

davidruvolo51 commented Jun 24, 2020

It has been a while since I've worked on this package. Since the last updates, I have rebuilt the browsertools package and have developed the rheroicons library. These packages should be integrated into accessibleshiny in favor of lightweight icons and optimized JS code. In addition, the following changes need to be made.

  • Rename the inst/assets to something more memorable and to prevent conflicts with other packages.
  • Expand use_* function to allow for the following.
    • setting the document language
    • setting the document direction
    • setting the document title
    • setting open graph data Will not implement
  • Update accordion component
    • replace icon with rheroicons
    • Use Shiny input bindings for toggle to handle the opening/closing of the card. The current method does not find elements that are rendered dynamically.
  • Updates/Checks for Progress bar
    • Consider alternative rendering methods for progress bar. There are some instances where page rendering triggers a complete redraw of the progress bar.
    • Consult with docs regarding updating aria props
  • Datatable component
    • Consider options for multiple column headers
  • [ ] Integrate Parcel 2.0. (This will be ongoing as parcel2 is still in beta)
  • [ ] Update dev dependencies
@davidruvolo51 davidruvolo51 added the enhancement New feature or request label Jun 24, 2020
@davidruvolo51 davidruvolo51 self-assigned this Jun 24, 2020
@davidruvolo51 davidruvolo51 added this to To do in dev via automation Jun 24, 2020
@davidruvolo51
Copy link
Owner Author

davidruvolo51 commented Sep 21, 2020

  • Rewrite progressbar component using method outlined in other application

@davidruvolo51
Copy link
Owner Author

davidruvolo51 commented Sep 21, 2020

**These tasks will not happen. Instead, switch to Webpack **

### Parcel v2 Notes

  • Upgrading to parcel2 is simpler than originally thought. Use targets to specify build instructions for each static asset type (i.e., demo vs pkg assets)
  • .babelrc is no longer required
  • .postcssrc can be simplified. Only autoprefixer is needed

@davidruvolo51 davidruvolo51 changed the title Improvements to Current Components Improvements to Current Components & New Features Oct 5, 2020
@davidruvolo51
Copy link
Owner Author

davidruvolo51 commented Oct 5, 2020

Import Accordion Input Component

  • Copy files from other package: R (main and helpers), SCSS, JS
  • Split SCSS into: common, accordion, and accordion input
  • Integrate style argument`
  • Improve R command line messages
  • Remove blur events in favor for :focus-within
  • Write unit tests

@davidruvolo51
Copy link
Owner Author

davidruvolo51 commented Oct 5, 2020

SCSS Features

  • Integrate CSS variables: this would make customizing the widgets much easier writing lengthy selectors. There should be package wide variables which are used in at the component-level and component children-level elements.

I would like to do the following when designed/developing an app.

// global styles
.accessibleshiny {
   --primary: blue;
}

// component level
.accordion__input {
   --primary: red;
}

// component child level
.accordion__input .accordion__heading {
   --primary: green;
}
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
dev
  
To do
Development

No branches or pull requests

1 participant