Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why disable inherit FontSize? #5

Closed
RichardRobertson opened this issue Jan 23, 2024 · 2 comments
Closed

Why disable inherit FontSize? #5

RichardRobertson opened this issue Jan 23, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@RichardRobertson
Copy link

I was updating Nuget packages and found that my buttons' content was larger than normal. It took a while to find out that the SymbolIcon was showing the wrong FontSize property and I couldn't figure out why until I found a commit ad81b51 describing exactly what I found.

Is there a change log somewhere that documents this? It was quite unexpected.

@davidxuang davidxuang added the question Further information is requested label Jan 24, 2024
@davidxuang
Copy link
Owner

Hi, this change is intended, to match the behavior of <SymbolIcon> and <FontIcon> on UWP/WinUI, where:

  • <SymbolIcon> has a fixed size of 20, you need <Viewbox> to resize it;
  • <FontIcon> has default font size of 20, and not inheriting from parent element.

Sorry this was not documented because it is recongised as a bug (as of to match WinUI behavior). I originally planned to update the README after another epic update, where I will build the font from scratch (instead of grabbing from upstream), to provide better RTL support and add a font variant that matches the appearence (mostly size and stroke width).

davidxuang added a commit that referenced this issue Jan 24, 2024
@RichardRobertson
Copy link
Author

Ok, I guess it makes sense from that perspective, but I wonder why the origin chose not to inherit, as is the standard for text elements in Xaml. Thanks.

@davidxuang davidxuang added the documentation Improvements or additions to documentation label Jan 24, 2024
@davidxuang davidxuang removed the question Further information is requested label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants