Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowMultiple=false doesn't prevent array of activeItems #65

Closed
psimyn opened this issue May 2, 2016 · 1 comment
Closed

allowMultiple=false doesn't prevent array of activeItems #65

psimyn opened this issue May 2, 2016 · 1 comment

Comments

@psimyn
Copy link
Contributor

psimyn commented May 2, 2016

Probably similar to #51

Example:

<Accordion allowMultiple={false} activeItems={[0,1,2]}>
</Accordion>
  • When the page first loads then 0, 1, 2 are expanded
  • Click item 1 it will close and others (multiple) will remain open
  • Click item 1 again it will re-open, and then the others will close

Possible solutions:

  • warn/error if passing an array when allowMultiple is false
  • grab the first entry, ignore rest of array
  • don't worry about it this isn't a very serious issue
@psimyn
Copy link
Contributor Author

psimyn commented May 8, 2016

fixed with #74

@psimyn psimyn closed this as completed May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant