Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tag a new release fixing python 3.11 support #2791

Closed
pacho2 opened this issue May 4, 2023 · 13 comments
Closed

[Bug]: Tag a new release fixing python 3.11 support #2791

pacho2 opened this issue May 4, 2023 · 13 comments
Labels

Comments

@pacho2
Copy link

pacho2 commented May 4, 2023

What Operating System(s) are you seeing this problem on?

Linux (x86-64)

dlib version

19.24

Python version

3.11

Compiler

GCC 12

Expected Behavior

python 3.11 is landing on several arches and current version does not build with it. I think a new release including the fixes in master would be interesting then

Thanks

Current Behavior

Fails to build with python 3.11
#2734
#2659

Steps to Reproduce

Try to build it with python 3.11 and hit known bugs of latest release

Anything else?

No response

@pacho2 pacho2 added the bug label May 4, 2023
@s0ulslack
Copy link

This is annoying me on Gentoo atm

@cheanus
Copy link

cheanus commented May 5, 2023

Same problem

@davisking
Copy link
Owner

What is the issue here exactly? I just now did pip install dlib on Ubuntu using Python 3.11.2 and dlib installed and appears to work as normal.

@pacho2
Copy link
Author

pacho2 commented May 6, 2023

Then maybe a newer release is being offered in pip over github releases 🤔

@davisking
Copy link
Owner

Oh, you all using the v19.24 tag in github?

@pacho2
Copy link
Author

pacho2 commented May 7, 2023

Many distributions, not only on Gentoo:
https://repology.org/project/dlib/versions

@davisking
Copy link
Owner

Yeah in pip there is a dlib 19.24.1 that is basically what's in git master right now. We are still working on some stuff, and will tag an official 19.25 in a month maybe.

@s0ulslack
Copy link

Who packages git branches besides Arch folks, terrible practice! Looking forward to an easy update sooner than later

@davisking
Copy link
Owner

I'm not sure what exactly you are asking for. You just want me to make a git tag for you like 19.24.2?

@arrufat
Copy link
Contributor

arrufat commented May 11, 2023

This is annoying me on Gentoo atm

But you're using Gentoo, compiling packages should be your bread and butter.

@pacho2
Copy link
Author

pacho2 commented May 14, 2023

I'm not sure what exactly you are asking for. You just want me to make a git tag for you like 19.24.2?

Synchronize the releases with the fixed version from pip... it seems 19.24.1 has the needed fixes per the comments here, but the last tag and release in github is from Nov 2022 and is not compatible with python 3.11

Thanks

@davisking
Copy link
Owner

No problem, just tagged v19.24.2.

@pacho2
Copy link
Author

pacho2 commented Jun 8, 2023

It works fine, thanks a lot!

@pacho2 pacho2 closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants