SUSPENDED state not detected correctly

[sempervictus]

We had a failure go unnoticed this morning - pool shows up as ONLINE in Zenoss (with no IO in the graphs) but went SUSPENDED on the host hours ago.
Zenoss 6.3 with zenpack built off of 8a17ca6
Thanks as always

[daviswr]

Any chance you could email me the zpool status output from the host? Would need to run the output through the parsing code to see where the breakdown is.

[daviswr]

Pretty sure the problem lies here

ZenPacks.daviswr.ZFS/ZenPacks/daviswr/ZFS/zenpack.yaml

Lines 1022 to 1026 in 9607f90

	zpool-status:
	usessh: true
	commandTemplate: |-
	$$ZENOTHING
	${here/PrivEscCmd} ${here/ZpoolPath} status -v "${here/title}" | grep -e "${here/title}" -e scrub -e scan

since the state: line in zpool status output is omitted by the grep before it gets to the parser.

Shouldn't be too bad to correct.

I've opened #14 to track generating events based on state & error fields, too.

[sempervictus]

Thank you sir, will pull in and test the changes this week

[daviswr]

I believe I've fixed this, but given the commit you're at currently, I'd recommend uninstalling the pack and then building and installing an updated one. Deprecated some relationships that never actually made it into .egg releases and it won't depend on the TALES patch as of last month. Also device-level thresholds will be gone in favor of pool-level.