Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded URLs not declared as static #1

Closed
Adrisui3 opened this issue Nov 22, 2023 · 1 comment
Closed

Hardcoded URLs not declared as static #1

Adrisui3 opened this issue Nov 22, 2023 · 1 comment

Comments

@Adrisui3
Copy link

Attributes for the GameCrontroller class holding the base URLs for data providers should be declared static as they are not defined per instance. Also, please consider using uppercase for static constants within a class. For instance: STEAM_API_BASE.

image
@daviyisu
Copy link
Owner

Done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Adrisui3 @daviyisu