Make pcal recognise the start day #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour of the Unix utility "cal" is to start the week on the day that corresponds to the LC_TIME locale. Under en_GB, it's Monday, under en_US, it's Sunday (and under cs_CZ, it's Pondělí, which corresponds to Monday). Adding the third argument to pcal makes it possible to emulate at least both the English approaches. The expected behaviour is the following commands should succeed: pcal 7 2023 1 | diff -wB - <(LC_ALL=en_GB.utf8 cal) pcal 7 2023 0 | diff -wB - <(LC_ALL=en_US.utf8 cal)
|
Greetings from the Pull Request Club. |
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of the Unix utility "cal" is to start the week on the day that corresponds to the LC_TIME locale. Under en_GB, it's Monday, under en_US, it's Sunday (and under cs_CZ, it's Pondělí, which corresponds to Monday). Adding the third argument to pcal makes it possible to emulate at least both the English approaches.
The expected behaviour is the following commands should succeed:
pcal 7 2023 1 | diff -wB - <(LC_ALL=en_GB.utf8 cal)
pcal 7 2023 0 | diff -wB - <(LC_ALL=en_US.utf8 cal)