Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the 'yy-mm-dd' format to pass the 'start' and 'end' date when instanciating an event class #5

Merged
merged 2 commits into from Oct 25, 2022

Conversation

tcheukueppo
Copy link
Contributor

@tcheukueppo tcheukueppo commented Oct 23, 2022

Hello Dave,

Completes PR #2

Given that the unit of measurement is year, we gotta add a subroutine which converts the date attributes (end and start of format yy-mm-dd) into their corresponding floating years.

@coveralls
Copy link

coveralls commented Oct 23, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling a985403 on tcheukueppo:fractions into 0a5775a on davorg:master.

@davorg davorg changed the base branch from master to floating-point-date October 25, 2022 13:32
@davorg davorg merged commit 6ec3ba0 into davorg-cpan:floating-point-date Oct 25, 2022
@davorg
Copy link
Collaborator

davorg commented Oct 30, 2022

Hi,

In the end, I took a slightly different approach here, but your code was still useful in order to understand what's possible.

Version 0.1.0 is on the way to CPAN now.

Thanks...

@tcheukueppo
Copy link
Contributor Author

You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants