Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove state from unstructured data and IO functions #12

Closed
dawe opened this issue Apr 13, 2021 · 2 comments
Closed

Remove state from unstructured data and IO functions #12

dawe opened this issue Apr 13, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@dawe
Copy link
Owner

dawe commented Apr 13, 2021

Since all annotation levels are stored, we can remove the need to keep gt.NestedBlockState in adata.uns['schist']. Once annotations are present, a new state can be easily reconstructed, given that

  • the graph can be built from connectivities
  • the block state can be built from nsbm_level entries in adata.obs

This can be done if we make sure that all parameters are stored in the appropriate dictionary.
If this is implemented, there is no need to use schist.io functions to read/write as they are there only to dump the state into a separate pickle

@dawe dawe added the enhancement New feature or request label Apr 13, 2021
@dawe dawe assigned leomorelli and unassigned leomorelli Apr 13, 2021
@dawe
Copy link
Owner Author

dawe commented Oct 15, 2021

This has been addressed in v0.7.10. Unfortunately I realized there's a bug now with nested models as you cannot place lists of lists in adata.uns

@dawe
Copy link
Owner Author

dawe commented Oct 15, 2021

Fixed in v0.7.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants