Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"From" field is required/optional? #188

Open
iRupam opened this issue Dec 29, 2023 · 0 comments
Open

"From" field is required/optional? #188

iRupam opened this issue Dec 29, 2023 · 0 comments

Comments

@iRupam
Copy link

iRupam commented Dec 29, 2023

@dawidd6 I've gone through the code. Didn't get why we're listing "from" field when we've already defined login credentials in GitHub Secrets. Also what's the result if we put wrong "from" field? Won't it simply disallow the mail sending? I am using Gmail alias BTW! Let me know your take on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant