Add line number vertical line

[pakLebah]

Actual Behavior

Complaint: The space between line number and the actual code is too close. On some themes, the color similarity of line number and the code is confusing.

Expected Behavior

Suggestions:

1. The space between line number and the code should be a little bit wider.
2. Add a vertical line to clearly distinguish line number and the code.

[DeepSpace2]

While at it, maybe make the line optional and the padding configurable?

[mfix22]

@DeepSpace2 the line numbers are optional and the padding is currently configurable in the settings. Just click "Advanced" in the dropdown.

@jakedex what do you think about having this line next to the line numbers?

[adrianhartanto0]

can I work on adding the line next to the line numbers?

[mfix22]

Sure @adrianhartanto0! Could you add it as an option to start though, under the "Advanced Settings" menu?

[adrianhartanto0]

@mfix22 no problem. will update any progress

[adrianhartanto0]

@mfix22 Shall the vertical line be fixed to a particular color/colour? If so, what color should it be?

[mfix22]

They should be the same color as the line numbers. I am not sure if those colors are set by the theme, or just by Codemirror itself. Either way that is managed by Codemirror, not Carbon at the moment, so that would be the first place to look (:

…

On Mon, May 28, 2018 at 9:35 AM, adrianhartanto0 ***@***.***> wrote: @mfix22 <https://github.com/mfix22> Shall the vertical line be fixed to a particular color? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#351 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAjjJrX2SW9_Q4WXIesO47BKSpZacllks5t3CdigaJpZM4Ts4X1> .

[jakedex]

Closing as stale. See #384