fix base64 bug #412
Merged
fix base64 bug #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Base64 table has Char '+' [https://en.wikipedia.org/wiki/Base64](https://en.wikipedia.org/wiki/Base64), it will turn to blank characters in url request, It will cause some error when deserializeState the state.
|
Hey @mashihua thanks for the PR! |
mfix22
approved these changes
Jun 27, 2018
briandennis
reviewed
Jun 27, 2018
handlers/image.js
Outdated
| @@ -9,7 +9,7 @@ module.exports = browser => async (req, res) => { | |||
| if (!state) res.status(400).send() | |||
|
|
|||
| try { | |||
| await page.goto(`http://localhost:${PORT}?state=${state}`) | |||
| await page.goto(`http://localhost:${PORT}?state=${encodeURIComponent(state)}`) | |||
There was a problem hiding this comment.
We should be handling this properly in the serialize/deserialize functions rather than inline on the handler
There was a problem hiding this comment.
Hey @mashihua can you move encodeURIComponent into the function @briandennis mentioned above? (:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Base64 table has Char '+' https://en.wikipedia.org/wiki/Base64, it will turn to blank characters in url request, It will cause some error when deserializeState the state.
Description