Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should overwrite text #42

Closed
garyking opened this issue Mar 11, 2020 · 3 comments · Fixed by #44
Closed

Should overwrite text #42

garyking opened this issue Mar 11, 2020 · 3 comments · Fixed by #44

Comments

@garyking
Copy link

If text is selected, and an item is selected from this extension, then the item is appended to the selection, rather than replacing it, as you would expect.

So instead, it should replace the selected text.

@dawsbot
Copy link
Owner

dawsbot commented Mar 11, 2020

That's a decent feature suggestion. I have never thought of this use case, but if you want to PR this, we're happy to take a look and consider merging!

You can run your forked version of this on your machine to test.

@rapsalands
Copy link
Contributor

rapsalands commented Apr 26, 2020

Pull request to address this issue #44.

@dawsbot
Copy link
Owner

dawsbot commented Apr 27, 2020

@rapsalands superb, thank you. In the future, you can say closes #42 or fixes #42 in your PR description and github will automatically close this issue when that's merged AND link people between the two 🔗 🙌 (I went ahead and edited and added that into your PR description over in #44 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants