✨ Allow optional chainId or short network name into getNetwork
#122
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if (network) { | ||
| [eeNetwork, ethersNetwork] = await Promise.all([ | ||
| essentialEth.getNetwork(network), | ||
| ethers.providers.getNetwork(network), |
There was a problem hiding this comment.
@dawsbot you'll notice on here, comparing to the test below, that ethers actually has two separate getNetwork functions: one called on a provider to get the network that provider is using, and another more util-like function to get the information about a specified network. Given this, I'm thinking that it'd be better for us to split them up as well. If that plan makes sense, it seems like the easiest approach is to add this as a new util fn, instead of how ethers exports their providers package
Thoughts?
There was a problem hiding this comment.
Aha, yes yes, this is a great point.
Soon this package too should split into utils and provider. I will do this with #105, and then this PR can continue. Let's put this task to a "blocked" column for now on the task board (I've just made a new column for that)
|
Closing for now since I've left this stale and didn't improve anything here 🙏 |
Closes #85
NetworkishgetNetworkprocess chainId numbergetNetworkprocess short network namegetNetworkprocess deep equality on full network object