[not ready] Fix scraper #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsbot
commented
Mar 6, 2024
scripts/puppeteer-fetch-all.ts
Outdated
| function openBrowser(): Promise<puppeteer.Browser> { | ||
| return puppeteer.connect({ | ||
| browserWSEndpoint: | ||
| "ws://127.0.0.1:9222/devtools/browser/af1a102b-63b1-41f8-bb83-7e4f6d4d1f22", |
There was a problem hiding this comment.
We are going to swap this out.
puppeteer-core will become playwright and we will also undo this browserWSEndpoint hack and just connect to the default (probably chrome).
The downside of this is that we will likely also need to do a login when on the Etherscan page immediately since the rate-limits are stricter for logged-out users
* fix error parsing and add dynamic hostname generation\n\nadded error-parse.ts which contains a function taking in any js Error type and displays a user readable error that goes a little more in depth.\nin puppeteer-fetch-all.ts i imported the hostname function from the os library in js and put it in place for the static '127.0.0.1' previously used in openBrowser() * revert readme.md * revert readme * Move from puppeteer to playwright --------- Co-authored-by: dawsbot <dawsonbotsford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.