fix error parsing and add dynamic hostname generation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parse.ts which contains a function taking in any js Error type and displays a user readable error that goes a little more in depth.\nin puppeteer-fetch-all.ts i imported the hostname function from the os library in js and put it in place for the static '127.0.0.1' previously used in openBrowser()
dawsbot
reviewed
Mar 8, 2024
readme.md
Outdated
|
|
||
| The file of concern is `scripts/puppeteer-fetch-all.ts` and can be executed with `npx tsx scripts/puppeteer-fetch-all.ts` |
There was a problem hiding this comment.
How come this contribution information is getting removed?
There was a problem hiding this comment.
this is strange, i did not make the readme a part of this commit. I will fix this before submitting next request
There was a problem hiding this comment.
I'll take care of this. For future reference, you can fix this with git checkout origin/master readme.md
dawsbot
reviewed
Mar 8, 2024
| const addressesHtml = await fetchPageHtml(url, browser); | ||
| const allAddresses = selectAllAddresses(addressesHtml); | ||
| console.dir({ url, allAddresses }); | ||
| try { |
There was a problem hiding this comment.
Good try/catch wrapper for error handling ✅
dawsbot
reviewed
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added error-parse.ts which contains a function taking in any js Error type and displays a user readable error that goes a little more in depth.\nin puppeteer-fetch-all.ts i imported the hostname function from the os library in js and put it in place for the static '127.0.0.1' previously used in openBrowser()