[Not ready] polygonscan #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewandishin
changed the title
|
What's not ready about this one @kylewandishin ? All the data looks expanded properly in the data files |
|
@dawsbot the tests do not include a test of the API pulling method. that is why I left it as not ready but I feel comfortable adding the rest |
dawsbot
reviewed
May 18, 2024
| @@ -38,6 +47,26 @@ export abstract class HtmlParser { | |||
| return anchors; | |||
| }; | |||
|
|
|||
| public async selectAllTokenAddressesApi( | |||
There was a problem hiding this comment.
An issue I'm finding with this approach is that an API fetch to etherscan does not relate to HTML parsing. Given the name of this class, this behavior would best be located in a different class @kylewandishin
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.