Add api unit tests #74
Conversation
kylewandishin
force-pushed
the
add-api-unit-tests
branch
from
adac005
to
e651ebd
Compare
kylewandishin
force-pushed
the
add-api-unit-tests
branch
from
13267d1
to
a0d293b
Compare
|
@dawsbot i have changed the code relating to all your feedback. please review the recent commits |
| @@ -63,7 +85,7 @@ export abstract class ApiParser { | |||
| public convertToTokenRows(data: ApiResponse): TokenRows { | |||
| const tokens = data.d.data.map((obj) => ({ | |||
| tokenName: obj.tokenName, | |||
| tokenSymbol: obj.tokenSymbol, | |||
| tokenSymbol: "", | |||
There was a problem hiding this comment.
How come the tokenSymbol is an empty string here?
There was a problem hiding this comment.
i found that token symbol is not on the API response and removed it from the type we made. this made it so that i could not just leave it as obj.tokenSymbol. it was essentially a blank string before as well because it is assigned in the filter data step.
There was a problem hiding this comment.
A more future-proof method in the future would be to leave out tokenSymbol from this atall since it's hydrated later and create a new TS type here so that we lean on TS to enforce we hydrate tokenSymbol in a later stage.
But in the effort to not over-complicate this is fine for now
@dawsbot please review this commit