-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Historical Rating Function Pointing to Incorrect Endpoint #34
Comments
I would agree with you. It appears I copy/pasted to make the "historical_rating" method but didn't change anything. This said, I've looked through the FMP API Docs and I don't see what I should have put here. I've been remiss on keeping up to date with changes/additions. The FMP API team seems to be regularly adding and changing things. During these changes it appears they must have restructured the API methods layout and categorization. At some point in the past they must of had some sort of "historical rating" endpoint but now I don't see it. So, do you see what endpoint historical_rating should point to? As an aside, I'll try to prioritize updating the fmpsdk python package to bring it more in sync with FMP's current API endpoints. |
I took a look and found the correct string. This is working for me:
|
I appreciate your prompt response earlier =] Like i mentioned, great job with the Lib! |
Updated and new version released. |
Hello,
Thank you for this great tool, very useful! I believe the historical_rating function in /fmpsdk/company_valuation.py may be pointing to the wrong API endpoint.
Please see below.
The text was updated successfully, but these errors were encountered: