Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on cljsjs/create-react-class #224

Closed
Deraen opened this issue Jan 7, 2019 · 1 comment
Closed

Missing dependency on cljsjs/create-react-class #224

Deraen opened this issue Jan 7, 2019 · 1 comment

Comments

@Deraen
Copy link
Contributor

Deraen commented Jan 7, 2019

Currently the bundled Reagent 0.6.0 uses create-react-class. However, re-frame-10x doesn't have dependency on cljsjs/create-react-class or other cljsjs libs used by Reagent. This is fine with Reagent up to 0.8.0 because users get the cljsjs libs through Reagent dependencies.

But Reagent 0.9.0 will drop dependency on create-react-class, so re-frame-10x breaks as the bundled Reagent can't find the create-react-class library, unless user adds direct dependency on create-react-class.

This can be tested with a project using Reagent 0.9.0-SNAPSHOT.

@danielcompton
Copy link
Contributor

Thanks for the heads up, I'll look at updating this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants