Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: goog.ui usage incompatible with shadow-cljs 2.22.0 and google-closure-library v20230227 #382

Closed
scarytom opened this issue Mar 9, 2023 · 4 comments
Labels

Comments

@scarytom
Copy link

scarytom commented Mar 9, 2023

What happened?

Getting an error in the browser console when loading my app locally (shadow-cljs watch) since upgrading from shadow-cljs 2.21.0 -> 2.22.0

The error does not occur if I remove the day8.re-frame-10x.preload preload.

This version bump of shadow-cljs comes with a massive bump in the underlying google closure library version (from v20211011 to v20230227) so I strongly suspect that some of the changes to goog.ui between those two versions are causing the issue.

This was discussed in the Clojurian's slack

10x Version

1.5.0

Reagent Version

1.2.0

React Version

17.0.2

re-frame Version

1.3.0

What browsers are you seeing the problem on?

Chrome

Relevant console output

TypeError: Cannot read properties of undefined (reading 'setDecoratorByClassName')
    at eval (control.js:106:54)
    at eval (<anonymous>)
    at goog.globalEval (app.js:430:11)
    at env.evalLoad (app.js:1387:12)
    at app.js:1656:12
@thheller
Copy link
Contributor

I identified the issue thheller/shadow-cljs#1097.

re-frame-10x isn't doing anything wrong, shadow-cljs is just confused. Will think about it for a bit, and should have a fix this weekend.

@thheller
Copy link
Contributor

Should be fixed in 2.22.1.

@rome-user
Copy link

Assuming everything works on the latest shadow-cljs, I think this issue can be closed

@scarytom
Copy link
Author

I've re-tested, and it all works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants