Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning when user tries to add a trace callback but hasn't set a closure-define #384

Closed
danielcompton opened this issue Jul 26, 2017 · 1 comment
Assignees

Comments

@danielcompton
Copy link
Contributor

danielcompton commented Jul 26, 2017

re-frame.trace/register-trace-cb doesn't validate whether the closure define to enable tracing has been set or not. This could lead to confusing situations where people are trying to use re-frame's tracing abilities, but haven't set the closure-define so no traces show up.

The fix for this is to check at re-frame.trace/register-trace-cb whether tracing is enabled or not, and log a warning if it isn't, telling the user that they need to set the closure define for re-frame.trace.trace-enabled?.

@superstructor
Copy link
Contributor

Fixed in a previous release. See this code. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants