Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externs Inference Warnings #591

Closed
superstructor opened this issue May 6, 2020 · 0 comments
Closed

Externs Inference Warnings #591

superstructor opened this issue May 6, 2020 · 0 comments
Assignees

Comments

@superstructor
Copy link
Contributor

superstructor commented May 6, 2020

Steps to Reproduce

Compile a re-frame project (e.g. todomvc example) with shadow-cljs settings of:

:compiler-options {:infer-externs :all}

Actual Behavior

------ WARNING #228 - :infer-warning -------------------------------------------
 Resource: re_frame/interop.cljs:22:3
 Cannot infer target type in expression (. x -reagent$ratom$IReactiveAtom$)
--------------------------------------------------------------------------------

------ WARNING #229 - :infer-warning -------------------------------------------
 Resource: re_frame/interop.cljs:51:9
 Cannot infer target type in expression (. reactive-val -reagent$ratom$IReactiveAtom$)
--------------------------------------------------------------------------------

Desired Behavior

No warnings from re-frame code.

We are only responsible for 2 out of 234 inference warnings on the todomvc app but we may as well fix our part of it.

A previous commit fixed a similar warning.

shadow-cljs user guide has some tips on fixing externs warnings.

@superstructor superstructor self-assigned this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant