Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for alwaysVisible to only apply when area is scrollable #9

Open
madeleineostoja opened this issue Apr 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@madeleineostoja
Copy link

madeleineostoja commented Apr 5, 2022

Following on from #4, it would be great if we had an option for alwaysVisible to only show the scrollbar if the area is scrollable. I guess you wouldn't want to change the default behaviour of the existing prop since that would be a breaking change, but I imagine you could overload it.

Eg:

  • alwaysVisible={true} current behaviour
  • alwaysVisible="scrollable" only visible if area is scrollable (content height > 100% of viewport height)
  • alwaysVisible="always" same as true
@daylilyfield
Copy link
Owner

@madeleineostoja thanks for your proposal. and i try to implement this feature in this weekend.

@daylilyfield daylilyfield self-assigned this Apr 15, 2022
@daylilyfield daylilyfield added bug Something isn't working and removed feat new feature labels Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants