-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize quality and performance #2
Comments
JIMP now actually supports different resizing algorithms: https://github.com/oliver-moran/jimp#resize-modes |
Yeah, performance goes down the drain as soon as you use this library in a real world scenario. I added a few images already the dev server takes 20x as long to boot up, I'm afraid to add anymore image.
|
I've had to pull this from my project as it's killing the build. I have about 30 large jpgs that it tries to generate srcset for and it just hangs. Sadly unusable in production at this time. Shame as it's the better one |
Yeah, probably a sharp "adapter" would be quite useful. Any thoughts on if this should be optional (use sharp when it's present, otherwise fall back to JIMP) or if we just should drop JIMP because it's too slow in practice? @sidonaldson how large are your JPGs? FWIW, we use it in production to generate ~200 regular sized JPGs and PNGs, and the build takes around 5min on Codeship (including all other assets). |
👍 for retaining JIMP, for future users which would like to run Webpack compilations in the browser and use |
I have a dirty WIP branch that's using Travis CI will need some tweaking to get |
Closed via #29 |
JIMP is pretty neat because it doesn't depend on some binary (makes it easy to run anywhere) but performance degrades quickly with many images.
Also, the resized image quality could be better (noticeable when scaling down 1px lines in transparent PNGs).
These problems could potentially be remedied with using another library/binary. Maybe add a configuration option for the 'engine'.
The text was updated successfully, but these errors were encountered: