feat: support ifNotExists when creating a postgres db #46
Conversation
andyburke
force-pushed
the
create_ifnotexists
branch
from
9b9c573
to
ddcffab
Compare
Signed-off-by: Andy Burke <andy.burke@mailbox.earth>
andyburke
force-pushed
the
create_ifnotexists
branch
from
ddcffab
to
b554d2b
Compare
|
Any feelings on this? |
|
Is this module still being maintained? |
|
It is but I am unfortunately very busy and do not always find time to invest. But I am very glad about all help and should you be willing to help maintaining this would be more than welcome! About your changes: Please note, never upgrade vows. there is an ugly bug in it and it completely breaks that is why the version is fixated. We still need to switch to lab for testing on this repo too, I just recently migrated the mysql one though. The changes look fine otherwise too me though. |
Signed-off-by: Andy Burke <aburke@bitflood.org>
andyburke
force-pushed
the
create_ifnotexists
branch
from
397cdbe
to
e0d3b34
Compare
|
I downgraded vows, but that means I cannot run the tests locally. Let me know if there's anything else needed before this can be merged. |
|
This actually does not work, and causes the drivers connection to be terminated immediately. Disabling for now. |
Search path could result in double quotes, due to spaces in the return of the database. Moving .trim() to manipulate the path early enough fixes this. Refers to #46 Signed-off-by: Tobias Gurtzick <magic@wizardtales.com>
Adds an implementation of ifNotExists for postgres when creating a database.
Unfortunately, this isn't as easy as adding some SQL. You need to use an extension, etc. I also had to update dependencies to get tests to run under a more recent version of node. Willing to work through feedback to try to get this accepted.