Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons: optional meta variables #169

Closed
mfranzke opened this issue Nov 24, 2022 · 0 comments
Closed

Icons: optional meta variables #169

mfranzke opened this issue Nov 24, 2022 · 0 comments
Assignees
@nmerget

Comments

@mfranzke
Copy link
Member 

    I like the idea making this optional, but in that case we could as well define it as a fallback to the CSS Variables reference on the following code lines:

https://github.com/db-ui/base/blob/cf16a3bd1e2078e5bf8209dbcc44884bc112c5b2/scss/icon/_icons.helpers.scss#L38L40

Originally posted by @mfranzke in #168 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmerget nmerget

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

169-icons-optional-meta-variables db-ui/base
2 participants
@mfranzke @nmerget