Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not setting node version for pipelines #262

Closed
mfranzke opened this issue Feb 20, 2023 · 0 comments · Fixed by #263
Closed

Not setting node version for pipelines #262

mfranzke opened this issue Feb 20, 2023 · 0 comments · Fixed by #263
Assignees
@mfranzke
Labels
bug Something isn't working cicd
Milestone
Release 1.0

Comments

@mfranzke
Copy link
Member

We're actually setting the node version for local development by .nvmrc, but not within the pipelines, which might result in unexpected problems.

This is most likely relevant for each dependent ci/cd helper we're using e.g. for installing dependencies, compare to https://github.com/bahmutov/npm-install#node-version
@mfranzke mfranzke added bug Something isn't working cicd labels Feb 20, 2023
@mfranzke mfranzke added this to the Release 1.0 milestone Feb 20, 2023
@mfranzke mfranzke self-assigned this Feb 20, 2023
@mfranzke mfranzke mentioned this issue Feb 20, 2023
Merged
@mfranzke mfranzke linked a pull request Feb 20, 2023 that will close this issue
refactor: set pipelines and local node versions equally #263
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfranzke mfranzke

Labels
bug Something isn't working cicd
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging a pull request may close this issue.

refactor: set pipelines and local node versions equally db-ui/base
1 participant
@mfranzke