Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fug: is code red or black? #737

Open
childnode opened this issue Feb 5, 2024 · 3 comments
Open

Fug: is code red or black? #737

childnode opened this issue Feb 5, 2024 · 3 comments
Labels
community feedback question Further information is requested
Milestone

Comments

@childnode
Copy link

core defines inline code `code` as black

color: darken($db-color-red, 2%);

but DB UI elements shows it mostly "color: inherit" style

don't know where it comes from https://github.com/search?q=repo%3Adb-ui%2Felements%20Consolas&type=code

what is the correct one and is it a Feature in core and a Bug in Elements or a Bug in Core and Feature in Elements?

regards
~Marcel

@mfranzke
Copy link
Member

mfranzke commented Feb 5, 2024

@childnode thanks a lot for your feedback.

Is there a special page within https://db-ui.github.io/elements/ that you're referring to?

@mfranzke mfranzke added question Further information is requested community feedback labels Feb 5, 2024
@mfranzke mfranzke added this to the Release 2.x milestone Feb 5, 2024
@childnode
Copy link
Author

No, i can`t find any declarative section for it neither on core nor on elements (nor on marketing portal).

I just opened the playground apps and hacked a code block in :)

@mfranzke
Copy link
Member

mfranzke commented Feb 6, 2024

@childnode I found that declaration, it's in there quite a while now. As code isn't defined in the standard, but we've only defined it within the technical implementation, it's not necessarily something that we've ever talked about with the creative colleagues (and that for we don't mention that code-HTML-element within the documentation itself so far). So if there's a problem that you've identified with the red color or the inconsistency, that you've reported, we could have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feedback question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants