Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBInput datalist element renders value as textNode #2642

Open
1 of 7 tasks
milan-w opened this issue May 14, 2024 · 0 comments · May be fixed by #2663
Open
1 of 7 tasks

DBInput datalist element renders value as textNode #2642

milan-w opened this issue May 14, 2024 · 0 comments · May be fixed by #2663
Labels
🐛bug Something isn't working

Comments

@milan-w
Copy link

milan-w commented May 14, 2024

Which generators are impacted?

  • All
  • HTML
  • React
  • Angular
  • Vue
  • Web components
  • Power Apps

Reproduction case

https://github.com/db-ui/mono/blob/main/packages/components/src/components/input/input.lite.tsx#L180
A datalist renders elements with a key as attribute and a value as text node.

Expected Behaviour

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/datalist

A datalist element only needs to contain an attribute "value" which holds the option value, the text node (here: option.value) is completely optional and should be treated as such. So additionally props.dataList should be an array of "string | KeyValueType".

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response

@mfranzke mfranzke added the 🐛bug Something isn't working label May 16, 2024
@nmerget nmerget linked a pull request May 21, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants