Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: rename Mount/MountFn to New/NewFn ? #24

Open
db47h opened this issue Jun 21, 2018 · 1 comment
Open

API: rename Mount/MountFn to New/NewFn ? #24

db47h opened this issue Jun 21, 2018 · 1 comment
Labels
API API change, possibly breaking

Comments

@db47h
Copy link
Owner

db47h commented Jun 21, 2018

This is a matter of perspective: It makes much more sense from a Go perspective (in which case Socket must go in favor of some more aptly named interface)

type NewFn func (w Wires) // or Wiring or ?

But then we have Circuit and other Chip...

@db47h db47h added the API API change, possibly breaking label Jun 21, 2018
@db47h
Copy link
Owner Author

db47h commented Jun 21, 2018

Socket has two public methods:

func (s *Socket) Wire(pinName string) *Wire {}
func (s *Socket) Bus(name string, size int) Bus {}

@db47h db47h added question Further information is requested and removed question Further information is requested labels Jun 21, 2018
@db47h db47h changed the title API: rename Mount/MountFn to New/NewFn API: rename Mount/MountFn to New/NewFn ? Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API change, possibly breaking
Projects
None yet
Development

No branches or pull requests

1 participant