-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails at start up, possibly by old gpu features #40
Comments
You are probably correct in that it is too old; but let's see if we can get more debug info. set the environment variable RUST_LOG=trace and run again, we should get a lot of debug output as wgpu tries to initialize the adapter. I am pretty sure this is a bug upstream; i think we should fail gracefully with an error message instead of panicking |
hi, I pasted below the full log, C:\dev\0086\martypc>martypc.exe |
It's interesting it's trying to use ANGLE. From what i'm seeing that is a backend for WebGL? It's true that other emulators may work well on your hardware, and clearly your system can probably emulate an 8088 just fine. Part of this is a consequence of the language I've chosen to use. The Rust ecosystem is still pretty young. I'm using a graphics library called 'wgpu', and they are doing some herculean efforts to support modern GPUs. But at some point it is too difficult and cumbersome to support older devices and drivers based on older versions of OpenGL and such. I have been considering making a software-based front end based on SDL instead of wgpu. It may not have the full debug interface, though it would in theory run on much older hardware. Just out of curiosity, are you able to use the MartyPC web player in your browser? |
here's the upstream issue for this in wgpu |
It works very good in browser (using Chrome), image and sound is choppy, losing frames, but not too much. |
Even @dbalsom's Ryzen 9 5900x can't run Area 5150 at full speed in all the effects with the web player, but my Ryzen 7 7700x can, so I highly doubt a Thinkpad X220 is fast enough. You might want to upgrade your PC. |
Or I need to optimize more :D |
Hi, impressive work!
I was doing a test of this little marvel in my old notebook, Thinkpad x220,
I am sure it has a crappy GPU. But maybe it's a better way to indicate the user minimum features needed ;)
I've read in the Wiki that it should have poor performance in old adapters.
so maybe this is an error?
Using ROM: ./roms\BIOS_5160_09MAY86_U18_59X7268_62X0890_27256_F800.BIN
Using ROM: ./roms\BIOS_5160_09MAY86_U19_62X0819_68X4370_27256_F000.BIN
Using ROM: ./roms\ibm_xebec_62x0822_1985.bin
Loaded 3 roms in romset.
Found floppy image: "./floppy\8088MPH (Final Version).img" size: 737280
Found floppy image: "./floppy\Area 5150 (Compo Version).img" size: 737280
Found floppy image: "./floppy\cgacomp.img" size: 737280
Found floppy image: "./floppy\FreeDOS 1.3 Disk 1 (Boot me).img" size: 368640
Found floppy image: "./floppy\FreeDOS 1.3 Disk 2.img" size: 368640
Found floppy image: "./floppy\Marty Utilities.img" size: 368640
Found floppy image: "./floppy\Ratillery (CGA).img" size: 368640
Found floppy image: "./floppy\Stellar Roads (CGA).img" size: 368640
thread 'main' panicked at 'called glObjectLabel but it was not loaded.', C:\Users\Daniel.cargo\registry\src\github.com-1ecc6299db9ec823\glow-0.12.2\src\gl46.rs:4571:5
Running with full Rust trace, I got the stack dump if it helps
stack backtrace:
0: 0x7ff6647cbb27 -
1: 0x7ff66436815b -
2: 0x7ff6647afe51 -
3: 0x7ff6647cdbeb -
4: 0x7ff6647cd7c7 -
5: 0x7ff6647ce633 -
6: 0x7ff6647ce0d5 -
7: 0x7ff6647ce01f -
8: 0x7ff6647cdff4 -
9: 0x7ff664b674b5 -
10: 0x7ff664b6dbd6 -
11: 0x7ff664b0ed74 -
12: 0x7ff6648fbb22 -
13: 0x7ff66497bf7a -
14: 0x7ff6645a4a70 -
15: 0x7ff66451804c -
16: 0x7ff66457b399 -
17: 0x7ff6644c3f99 -
18: 0x7ff6644c3fa6 -
19: 0x7ff6644c3b74 -
20: 0x7ff664b65d0c -
21: 0x7ffffa947614 - BaseThreadInitThunk
22: 0x7ffffc7426f1 - RtlUserThreadStart
Regards!
The text was updated successfully, but these errors were encountered: