Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for attachment_link #57

Closed
florianm opened this issue Apr 16, 2020 · 1 comment
Closed

Documentation for attachment_link #57

florianm opened this issue Apr 16, 2020 · 1 comment
Assignees
Milestone

Comments

@florianm
Copy link
Collaborator

Feature

Source ropensci/software-review#335 (comment)

I also noticed that attachment_link appears to be a place holder for functionality you intend to bring up in the future. It isn't demonstrated in the vignettes, and it has a TODO note in it that indicates that you will be improving this function to use the form schema to find attachment fields, like you did for ru_datatime. I am not sure the best approach here, but I think it's worth considering putting this in a development branch for now if it is not fully implemented. I might be wrong about your intentions here, so pardon me if that is the case. Would it make sense to do what this function does when a user calls handle_ru_attachments?

@florianm florianm added this to the rOpenSci milestone Apr 16, 2020
@florianm florianm self-assigned this Apr 16, 2020
@florianm
Copy link
Collaborator Author

  • submission_export exports a ZIP archive of all submissions as CSV, plus all attachment media.
  • attachment_link prepends the attachment filenames in the CSV with the attachment media folder.

The TODO note refers to the intent to introspect the form_schema to find column names of attachment files. This is now implemented as follows:

  • attachment_link introspects form_schema to get attachment field names
  • attachment_link params: added form_schema, dropped att_contains

attachment_link usage is (still) demonstrated in examples and (updated) in vignette "restful-api" under "submission_export".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant