Fix bug when completing "ON parent." clauses #42
Conversation
Previously, the code passed the wrong arguments to `identifiers`. Fixes dbcli#40.
| Column(tables=((None, 'tabl', 'a'),), drop_unique=None), | ||
| Table(schema='a'), | ||
| View(schema='a'), | ||
| Function(schema='a', filter=None)) |
There was a problem hiding this comment.
I'm not super confident about this test. Did I do it correctly?
|
I think we also want to add |
I think that's for completing the word |
It's the first part:
but I can move that out to a separate issue 👍 |
|
Ah, sorry, I missed that part. |
There was a problem hiding this comment.
@getaaron @pgr0ss Thanks for fixing the bug, it looks good to me.
Could you please also update the changelog and add yourself to the AUTHORS.rst?
For the JOIN and ON keywords, you can decided to add them in this CR or in a separate CR. Thanks again.
| Column(tables=((None, 'tabl', 'a'),), drop_unique=None), | ||
| Table(schema='a'), | ||
| View(schema='a'), | ||
| Function(schema='a', filter=None)) |
|
@pgr0ss We appreciate your help and want to give you credit. Please take a moment to put an
|
|
@zzl0 I don't seem to be able to check those boxes, but I've done both. |
It's fine, thanks |
Previously, the code passed the wrong arguments to
identifiers.Fixes #40.
This is my first time working in this project, so any and all feedback is welcome!