Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release (1.4.0) not working if athenaclirc file not in path #56

Closed
pdpark opened this issue Jun 9, 2020 · 7 comments
Closed
Assignees

Comments

@pdpark
Copy link
Contributor

pdpark commented Jun 9, 2020

athenacli works with version 1.3.3, but I get this message when trying to run athenacli 1.4.0:

Required argument `s3_staging_dir` or `work_group` not found.

There was an error while connecting to AWS Athena. It could be caused due to
missing/incomplete configuration. Please verify the configuration in ~/.athenacli/athenaclirc
and run athenacli again.
@zzl0
Copy link
Contributor

zzl0 commented Jun 9, 2020

Thanks for the feedback, taking a look

@zzl0 zzl0 self-assigned this Jun 9, 2020
@zzl0
Copy link
Contributor

zzl0 commented Jun 9, 2020

@pdpark sorry to ask for this. But I cannot reproduce the error on my side if have set s3_staging_dir either in athenaclirc or AWS_ATHENA_S3_STAGING_DIR env var.

Do you mind providing more info to reproduce this problem? how do you set the value for s3_staging_dir?

@pdpark pdpark changed the title Latest release (1.4.0) not working Latest release (1.4.0) not working if athenaclirc file not in path Jun 9, 2020
@pdpark
Copy link
Contributor Author

pdpark commented Jun 9, 2020

I found the issue and submitted PR #57 to fix it. A change in the 1.4.0 release requires that the athenaclirc file be in the PATH env var. This was not the case before - since the default location of the file is hard-coded in main.py file we know where to expect it: under the user's home dir.

@zzl0
Copy link
Contributor

zzl0 commented Jun 9, 2020

Thanks @pdpark . I made a mistake when I was verifying it, my virtual env had the old version, but I thought it was the new version.

@pdpark
Copy link
Contributor Author

pdpark commented Jun 9, 2020

NP, thanks for the quick response!

@zzl0
Copy link
Contributor

zzl0 commented Jun 10, 2020

I will create a new release tonight. Thank you so much for fixing it.

@zzl0
Copy link
Contributor

zzl0 commented Jun 11, 2020

Fixed in release v1.4.1. I also did some minor changes. Feel free to reopen this if you the issue still exists.

@zzl0 zzl0 closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants