Add cli option --tls-version to control tls version used #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amjith
reviewed
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #1073 +/- ##
==========================================
- Coverage 67.92% 67.10% -0.82%
==========================================
Files 26 26
Lines 2756 2791 +35
==========================================
+ Hits 1872 1873 +1
- Misses 884 918 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Might be good to consider lists/ranges of TLS versions.
Might be good to by default only allow TLSv1.2 and up. See RFC 8996 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1053.
This PR adds a
--tls-versionoption, parallel to the option of the vanilla mysql client.It was implemented by bypassing PyMySQL's ssl logic and creating the SSLContext ourselves.
This PR is currently a draft, as it would require raising the minimum python version to 3.7, as 3.6 has no way to force TLSv1.3.
Specifically,
SSLContext.minimum_versionwas only added in 3.7.However, PyMySQL's next update will require 3.7 as well.
This could alternatively be partially implemented inside PyMySQL as well. However, it is a documented option to pass a SSLContext to PyMySQL directly, so this seemed like the easier option.
One downside is that the
_create_ssl_contextmethod was strongly influenced by the one in PyMySQL - does this need to be noted somewhere for copyright reasons?Checklist
changelog.md.AUTHORSfile (or it's already there).