Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load assembly version from nUpdateVersionAttribute in nUpdate Administration #33

Closed
dbforge opened this issue Apr 23, 2017 · 5 comments
Closed

Comments

@dbforge
Copy link
Owner

dbforge commented Apr 23, 2017

The nUpdateVersionAttribute has been designed for external access to the assembly's current version, but is not used in the feature provided by nUpdate Administration. This should be changed as this is the only reason why the attribute had been introduced.
I think that there may have been a merge conflict or any other problem as I am pretty sure this had already been implemented some time ago.

@dbforge dbforge changed the title L"oad assembly version" Load assembly version from nUpdateVersionAttribute in nUpdate Administration Apr 23, 2017
@dbforge dbforge self-assigned this Apr 23, 2017
@KillTrot
Copy link

Hello there,

How is it looking with this?

Greetings

@dbforge
Copy link
Owner Author

dbforge commented May 20, 2017

Hi,

I'm sorry, I need to admit that I haven't touched this, yet. The upcoming week I'll have my oral exam in French and I'm completely busy at the moment.
In 10 days, I'll have finished with everything and then I will directly stick to these issues. I think you may be waiting for another feature in nUpdate itself (as discussed in the other issue), but as this one is associated with it, that's no problem.
Is it ok for you to wait another two weeks maybe? After I've passed my exam in French, I may have two days available for changing this, if you'd need it very fast, now.
I'm sorry to disappoint you again, but this is not my intention at all.

Best,
Dominic

@KillTrot
Copy link

Hi,

I just wanted to hear that you don't forgot it:P

Take your time, i'm fine atm and have exams for myself. Good luck!

Greez

@dbforge
Copy link
Owner Author

dbforge commented May 20, 2017

No, I'm really looking forward to working on nUpdate again. :D So, I definitely do not forget about the issues I have right here.
Alright, then good luck to you, too!

Best,
Dominic

@dbforge
Copy link
Owner Author

dbforge commented May 30, 2017

Invalid issue. I've just found that this is actually implemented correctly, but I looked for it in the wrong class.
Nevertheless, I found that there needs to be a inproved check on the nUpdateVersionAttribute when activating this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants