Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateInstaller throw IOException #49

Closed
selway opened this issue Mar 8, 2018 · 4 comments
Closed

updateInstaller throw IOException #49

selway opened this issue Mar 8, 2018 · 4 comments

Comments

@selway
Copy link
Contributor

selway commented Mar 8, 2018

Version: 3.2.1
image

It doesn't happen every time. But, every time this error occurs, the host app directory in Temp is always not cleared. So I added a log in MainForm.Fail(Exception ex),
like this:
System.IO.File.AppendAllText(@"D:\installerLog.txt", ex.StackTrace);
The StackTrace:
在 System.IO.Directory.DeleteHelper(String fullPath, String userPath, Boolean recursive, Boolean throwOnTopLevelDirectoryNotFound) 在 System.IO.Directory.Delete(String fullPath, String userPath, Boolean recursive, Boolean checkHost) 在 nUpdate.UpdateInstaller.Updater.CleanUp()

I think it is it was caused by calling Directory.Delete when the thread did not release the host app directory in 'Temp'.

P.S. It is difficult to cause this exception if the files in the update package are too small.

@dbforge
Copy link
Owner

dbforge commented Mar 8, 2018

Hi,

it may be that this error has already been reported, but I could not fix it due to a lack of information and the fact that it is only temporarily appearing.
What is the content of the error message (I don't speak Chinese)? And do you have any code lines? Nevertheless, thanks for the debugging till this place.

Best,
Dominic

@selway
Copy link
Contributor Author

selway commented Mar 8, 2018

Sorry, it meants "The directory is not empty."

@dbforge
Copy link
Owner

dbforge commented Mar 8, 2018

Thank you. I will check that out and see, if I can get further information.

@dbforge
Copy link
Owner

dbforge commented May 23, 2018

Should be fixed by 720e563.

@dbforge dbforge closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants