Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower deprecated in May 2017 and not strictly needed, remove peerDendency #6

Closed
PeterRJones opened this issue Oct 20, 2017 · 1 comment

Comments

@PeterRJones
Copy link
Contributor

Rolex specifies bower as a peerDependency.

As a packaging dependency, bower is not required for rolex to run properly. (Our project uses Webpack/Browserify.). As of May 2017 bower has been deprecated as per Issue #2298 .

Lastly, and perhaps most importantly, if you run npm ls it will fail with a non-0 exit code if unfulfilled peerDepdencies are found, such as with rolex. Perhaps only an annoyance, but if you use npm ls to check the consistency of your build tree as part of a deployment pipeline, this error becomes more significant.

Is there anyway to remove the bower reference from your peerDependency ?

@dbkaplun
Copy link
Owner

Closed as of v1.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants