Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code 0 when an unhandled exception occurs in jdnssec-verify #10

Closed
SvenVD-be opened this issue Feb 13, 2019 · 1 comment
Closed

Comments

@SvenVD-be
Copy link

SvenVD-be commented Feb 13, 2019

Hi,

We are using this in our tests and are using the exit code to see if the jdnssec-verify passed it's test.

Now, when there is an unhandled exception (like this one: #9) then it exits with code 0, so this goes unnoticed for us.

Suggestion is to have a catch all for all exceptions in jdnssec-verify and to exit with non-zero code in that case.

Thanks

@dblacka
Copy link
Owner

dblacka commented Feb 26, 2019

I just added a System.exit(1) to the command line base class (CLBase), so all of the tools should exit with 1 if they throw an exception.

@dblacka dblacka closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants