Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow color maps to specify BOLD attributing switching to high intensity instead of bold type face #43

Closed
ejelly opened this issue Jan 27, 2015 · 7 comments
Labels
feature request ✨ New feature to be added wontfix

Comments

@ejelly
Copy link
Collaborator

ejelly commented Jan 27, 2015

Some terminals, like VGA, do not actually have a bold typeface but switch to the high intensity color map instead. We should support that.

@ejelly ejelly added the feature request ✨ New feature to be added label Jan 27, 2015
@pegrau
Copy link

pegrau commented May 14, 2015

Hello,

I understand that you don't want the tag b for the bold typeface.

What HTML resource you suggest to use to translate the bold type?

@JoeMerten
Copy link
Collaborator

As I understand, he wants an option to e.g. behave esc[33;1m like esc[93m appears.

@jahudgins
Copy link

Yes. This is important for a project I am working on. The output from jest tests coverage is output in bold. esc[32;1m instead of esc[32m which indicates bold.

@JoeMerten
Copy link
Collaborator

Just for a note:

For my understanding, terminal emulators are free to choice if they interpret esc[1m for bold type or bright color (see also https://en.wikipedia.org/wiki/ANSI_escape_code).

I'd checked some interpreters (see also https://github.com/JoeMerten/Jfe/blob/master/Framework/tools/AnsiColors.py) and found out that frontends which have black background (e.g. Kubuntu Konsole) tend to choose bright color, as were frontends which have white background rather using bold typeface instead.

For my opinion this is good behavior, as e.g. bright red looses contrast at white background but normal red with bold typeface got more attention. But on black background, the bright red is the better choice to earn more attention.

However, some frontends can be configured to apply either bright color or bold typeface for esc[1m (e.g. Kubuntu Konsole, Eclipse Ansi Console, …).

I think that it's not a big thing to implement the alternative behavior. But we need a suggestion how to configure this.

  • Maybe adding a checkbox to the custom color map configuration (option for each color map).
  • Or adding a checkbox to the jenkins job configuration.

What's your suggestion about this?

@jahudgins
Copy link

Either bold or bright would be ok. But it should still be the specified color. Right now ansi color on esc[32;1m displays bright (or maybe bold not sure) white. But it should be green (32) -- I don't think there needs to be an option for bold or bright.

@JoeMerten
Copy link
Collaborator

Just tried out with AnsiColor 0.5.0, it looks ok esc[32;1m displays bold green:

ansicolors

Please run AnsiColors.py on your Jenkins and post the result as a screenshot. We maybe have an issue with the current 0.5.2 about this which I have not tested until now.

@stale
Copy link

stale bot commented May 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 28, 2021
@stale stale bot closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ✨ New feature to be added wontfix
Projects
None yet
Development

No branches or pull requests

4 participants