Fixed OverflowException when a dialog template contains a SysListView32 control #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoemmi
force-pushed
the
issue41-SysListView32-in-dialog-template
branch
from
845e1e5
to
f20ff23
Compare
|
Excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DialogExTemplateControl.ToStringfailed, becauseControlClassIdis not an Int resource but a string (SysListView32).I added a dialog template with a
SysListView32to custom.exe, added a failing unit test, and fixed the issue.I also refactored
ResourceInfoTests.TestLoadto not process the test binaries in a loop, but to be called for each binary separatly.