Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket :close isn't properly restarting bot #51

Closed
dblock opened this issue Dec 24, 2015 · 2 comments
Closed

Socket :close isn't properly restarting bot #51

dblock opened this issue Dec 24, 2015 · 2 comments

Comments

@dblock
Copy link
Owner

dblock commented Dec 24, 2015

2015-12-24T13:18:48.644709+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-bot-0.5.1/lib/slack-ruby-bot/server.rb:61:in `restart!'
2015-12-24T13:18:48.644716+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-bot-0.5.1/lib/slack-ruby-bot/server.rb:61:in `restart!'
2015-12-24T13:18:48.644727+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-bot-0.5.1/lib/slack-ruby-bot/server.rb:61:in `restart!'
2015-12-24T13:18:48.644735+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-bot-0.5.1/lib/slack-ruby-bot/server.rb:61:in `restart!'
2015-12-24T13:18:48.644740+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-bot-0.5.1/lib/slack-ruby-bot/server.rb:61:in `restart!'
2015-12-24T13:18:48.644745+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-bot-0.5.1/lib/slack-ruby-bot/server.rb:61:in `restart!'
2015-12-24T13:18:48.644753+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-client-0.5.0/lib/slack/real_time/client.rb:102:in `block (2 levels) in run_loop'
2015-12-24T13:18:48.644717+00:00 app[web.1]: /app/vendor/bundle/ruby/2.2.0/gems/slack-ruby-bot-0.5.1/lib/slack-ruby-bot/server.rb:70:in `rescue in restart!'
@dblock
Copy link
Owner Author

dblock commented Dec 24, 2015

It doesn't look like dblock/slack-ruby-bot@fbd06a1 fixed this :(

@dblock dblock closed this as completed in 1cae4ce Dec 24, 2015
@dblock
Copy link
Owner Author

dblock commented Dec 24, 2015

The fix above will route a restart via SlackGamebot::Service.restart! which will disable a team that was turned off via account_inactive, so it won't loop forever causing stack overflows and what not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant