-
Notifications
You must be signed in to change notification settings - Fork 1
Rename waterbody_edge_list.json #31
Comments
I left this as waterbody_edge_list.json on purpose with the expectation that long run, we will decouple the waterbodies from flowpaths. Theoretically, the waterbody_edge_list is actually duplicative of the catchment_edge_list right now since they are 1:1. |
If there are no waterbodies (yet) should we just drop the waterbody_edge_list.json until there are? |
Possibly. It's kind of grey in my mind. A degenerate waterbody_edge_list is the catchment_edge_list ... so is it really a problem? |
The problem is probably more in semantics and managing expectations. |
Adding this note to get waterbody edge list. #' NOTE: In some cases, there is one waterbody per catchment. In this case,
#' the waterbody edge list will be identical to the catchment edge list and
#' the waterbodies will coorespond 1:1 with flowpath **features.** The intro vignette already has this paragraph:
Added to the README:
|
Since implementing
flowpath_data.geojson
,waterbody_edge_list.json
should semantically be calledflowpath_edge_list.json
.The text was updated successfully, but these errors were encountered: